Use a progress reporter to hint the current build status when run or debug a program#919
Merged
testforstephen merged 8 commits intomicrosoft:masterfrom Dec 15, 2020
Conversation
798be19 to
bb79764
Compare
bb79764 to
03ae5ce
Compare
Contributor
Author
|
A private vsix to test the progress reporter feature. https://github.com/testforstephen/vscode-test/blob/master/vscode-java-debug-0.29.1.vsix Below is a sample to show the progress reporter such as resolving main class, compiling workspace, resolving launch configuration. |
Member
|
I have one question: When do we need to manually call |
Contributor
Author
Good question, you don't need call it. It's supposed to be used by progressReporter.cancel(). |
jdneo
reviewed
Dec 9, 2020
jdneo
reviewed
Dec 9, 2020
jdneo
reviewed
Dec 10, 2020
3bbd4ce to
6bee9dd
Compare
Contributor
Author
|
Here is a new private vsix https://github.com/testforstephen/vscode-test/blob/master/vscode-java-debug-0.29.2.vsix |
jdneo
reviewed
Dec 15, 2020
jdneo
reviewed
Dec 15, 2020
jdneo
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR includes:
Use a consistent progress reporter to report the build status before running/debugging an application.
By default, progress notifications are used to display status. You can switch to using status bar to hint the progress by user settings
"java.silentNotification": true.Expose an extension API for test runner to use the same progress reporter. In addition, when third-party extensions such as test runner call the startDebugging API to start the debugger, they can add an attribute
__progressIdto the launchConfiguration so that the debugger can use the same progress reporter to report progress.