Skip to content

Comments

Allow to cancel resolveMainMethod codelens command#881

Merged
testforstephen merged 1 commit intomicrosoft:masterfrom
testforstephen:jinbo_cancel
Sep 11, 2020
Merged

Allow to cancel resolveMainMethod codelens command#881
testforstephen merged 1 commit intomicrosoft:masterfrom
testforstephen:jinbo_cancel

Conversation

@testforstephen
Copy link
Contributor

This works with PR microsoft/java-debug#350

@testforstephen
Copy link
Contributor Author

Try to edit a unit test file for a while, below is the profiling result.

resolveMainMethod command is triggered 21 times, but the resolveMainMethodCore only runs 13 times, that means the cancel is hit 8 times.
image

@testforstephen testforstephen merged commit e1c3d06 into microsoft:master Sep 11, 2020
@testforstephen testforstephen deleted the jinbo_cancel branch September 11, 2020 03:07
@testforstephen testforstephen added this to the 0.29.0 milestone Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants