Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

remove black space after auto completed brackets #628

Merged
merged 1 commit into from
Nov 21, 2016

Conversation

jimmykuu
Copy link
Contributor

when "go.useCodeSnippetsOnFunctionSuggest": true,if a function auto completed brackets,there are a black space will insert after it. This's pull request will fix it.

@msftclas
Copy link

Hi @jimmykuu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@ramya-rao-a ramya-rao-a merged commit be446af into microsoft:master Nov 21, 2016
@jimmykuu
Copy link
Contributor Author

@ramya-rao-a src/goSuggest.ts doesn't changed. so 0.6.50 this problem is still existed.

@ramya-rao-a
Copy link
Contributor

Sorry, there must have been a merge conflict. Its in now. 32a3923

@ramya-rao-a
Copy link
Contributor

@jimmykuu The latest version 0.6.51 has your change.

mattetti added a commit to mattetti/vscode-go that referenced this pull request Jan 11, 2017
* 'master' of github.com:mattetti/vscode-go: (128 commits)
  Add telemetry support for the Go extension
  Add dlv path to error msg when dlv not found
  Fixes microsoft#465 outline offset problem in No-English language (microsoft#699)
  fix coverage display when editor changes to undefined (microsoft#693)
  Add support for reading http.proxy setting (microsoft#639)
  Fixing flaky unit tests
  Refactor for corner cases
  Reduce noise in console log due to errors from hover
  Changelog for next update 0.6.51
  Remove space after brackets in snippet as per microsoft#628
  Fixes microsoft#647 Strip version from autocompleted pkgs from gopkg.in (microsoft#659)
  Fixes microsoft#647 Support vendor pkgs from root of GOPATH/src (microsoft#660)
  Fixes microsoft#640 Use spawn to handle big data from gocode (microsoft#661)
  Fixed wrong workspace when one gopath is the substring of another. (microsoft#658)
  Fix "gotests" when generates test for current function for type methods (microsoft#657)
  Add benchmark function snippet (microsoft#648)
  Fix "Go to Definition" when running Go HEAD (microsoft#655)
  Fixes microsoft#642 Only add -d once to formatflags (microsoft#644)
  Updating Changelog and package.json for 0.6.50 update
  Log errors to console
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants