This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
delete and recreate go.mod instead of running go mod tidy #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Dec 17, 2019
src/goInstallTools.ts
Outdated
| @@ -148,16 +144,19 @@ export function installTools(missing: Tool[], goVersion: GoVersion): Promise<voi | |||
| envForTools['GO111MODULE'] = 'on'; | |||
| } | |||
|
|
|||
| // Write a temporary go.mod file. This shouldn't affect anything if we've explicitly disabled modules. | |||
| const tmpGoModFile = path.join(toolsTmpDir, 'go.mod'); | |||
| fs.writeFileSync(tmpGoModFile, 'module tools'); | |||
There was a problem hiding this comment.
With this, we are creating a new go.mod file for each tool being installed right?
In that case, should we move it inside the else block of the if (modulesOffForTool) check a few lines above?
There was a problem hiding this comment.
Also, did you check if fs.writeFileSync fails gracefully if the file already exists?
There was a problem hiding this comment.
It shouldn't matter if we write the file even if modules are off, but I moved the check in case. fs.writeFileSync replaces the file if it already exists.
ramya-rao-a
approved these changes
Dec 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
go mod tidyis more error-prone than just deleting and recreating the file.Fixes #2936.