Add staticcheck fixes: #2231

README.md

@@ -36,7 +36,7 @@ Read the [Release Notes](https://github.com/Microsoft/vscode-go/wiki/Release-Not
 
 - Build-on-save to compile code and show build errors. (using `go build` and `go test`)
 - Vet-on-save to run `go vet` and show errors as warnings
-- Lint-on-save to show linting errors as warnings (using `golint`, `gometalinter`, `megacheck`, `golangci-lint` or `revive`)
+- Lint-on-save to show linting errors as warnings (using `golint`, `gometalinter`, `staticcheck`, `golangci-lint` or `revive`)
 - Semantic/Syntactic error reporting as you type (using `gotype-live`)
 
 ### Testing
@@ -107,7 +107,7 @@ If you want to run only specific linters (some linters are slow), you can modify
   "go.lintFlags": ["--disable=all", "--enable=errcheck"],
 ```
 
-Alternatively, you can use [megacheck](https://github.com/dominikh/go-tools/tree/master/cmd/megacheck) which 
+Alternatively, you can use [staticcheck](https://github.com/dominikh/go-tools/tree/master/cmd/staticcheck) which 
 may have significantly better performance than `gometalinter`, while only supporting a subset of the tools.
 
 Another alternative is [golangci-lint](https://github.com/golangci/golangci-lint) which shares some of the performance

package.json

@@ -573,9 +573,9 @@
           "enum": [
             "golint",
             "gometalinter",
-            "megacheck",
             "golangci-lint",
-            "revive"
+            "revive",
+            "staticcheck"
           ]
         },
         "go.lintFlags": {

src/goInstallTools.ts

@@ -36,7 +36,7 @@ const _allTools: { [key: string]: string } = {
 	'golint': 'golang.org/x/lint/golint',
 	'gotests': 'github.com/cweill/gotests/...',
 	'gometalinter': 'github.com/alecthomas/gometalinter',
-	'megacheck': 'honnef.co/go/tools/...',
+	'staticcheck': 'honnef.co/go/tools/...',
 	'golangci-lint': 'github.com/golangci/golangci-lint/cmd/golangci-lint',
 	'revive': 'github.com/mgechev/revive',
 	'go-langserver': 'github.com/sourcegraph/go-langserver',
@@ -67,7 +67,7 @@ const importantTools = [
 	'goimports',
 	'golint',
 	'gometalinter',
-	'megacheck',
+	'staticcheck',
 	'golangci-lint',
 	'revive',
 	'dlv'
@@ -122,8 +122,8 @@ function getTools(goVersion: SemVersion): string[] {
 		tools.push('gometalinter');
 	}
 
-	if (goConfig['lintTool'] === 'megacheck') {
-		tools.push('megacheck');
+	if (goConfig['lintTool'] === 'staticcheck') {
+		tools.push('staticcheck');
 	}
 
 	if (goConfig['lintTool'] === 'golangci-lint') {
@@ -179,9 +179,9 @@ export function installAllTools(updateExistingToolsOnly: boolean = false) {
 		'golint': '\t\t(Linter)',
 		'gotests': '\t\t(Generate unit tests)',
 		'gometalinter': 'Linter)',
-		'megacheck': '\t(Linter)',
 		'golangci-lint': 'Linter)',
 		'revive': '\t\t(Linter)',
+		'staticcheck': '\t(Linter)',
 		'go-langserver': '(Language Server)',
 		'dlv': '\t\t\t(Debugging)',
 		'fillstruct': '\t\t(Fill structs with defaults)'