This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Default stackTraceDepth to the value from package.json #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x1unix
reviewed
Dec 22, 2018
| @@ -271,7 +271,7 @@ class Delve { | |||
| } else if (typeof launchArgs['useApiV1'] === 'boolean') { | |||
| this.isApiV1 = launchArgs['useApiV1']; | |||
| } | |||
| this.stackTraceDepth = launchArgs.stackTraceDepth; | |||
| this.stackTraceDepth = launchArgs.stackTraceDepth || 50; | |||
There was a problem hiding this comment.
The default value should be probably stored as const to avoid magic number problem.
There was a problem hiding this comment.
I'm not sure where to place the constant since there are no other such constants in the file, should it be:
- Somewhere at file scope? If so, where exactly?
- Inside the class? (
private/public?) - Alternatively, we can
import/require/JSON.parsethepackage.jsonand get it from there. (import/requirewill require enabling the TypeScript settingresolveJsonModule)
It's also quite possible that there are other default values strawn around that aren't constant, but I haven't checked.
There was a problem hiding this comment.
It's also quite possible that there are other default values strawn around that aren't constant,
Yes, right around this line of code we have set defaults for other properties of the launchArgs variable.
This looks good to me for now. I'll pick up the const issue in some later refactoring
ramya-rao-a
approved these changes
Dec 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that defaults from the debugger
configurationAttributesin package.json are only used for auto-complete, and won't be filled in automatically if not given.Fixes #2187, and fixes #2196