Migrate to ESM and modernize build process #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* run as ESM module for the nodejs EH * bundle as CJS for web worker EH * use esbuild over webpack
jrieken
added a commit
to microsoft/vscode
that referenced
this pull request
May 7, 2025
This PR makes it possible to have an extension that uses ESM for the NodeJS EH and CJS for the web worker EH. A sample is the GH issue notebooks extension: microsoft/vscode-github-issue-notebooks#185 re #130367
jrieken
added a commit
to microsoft/vscode
that referenced
this pull request
May 7, 2025
This PR makes it possible to have an extension that uses ESM for the NodeJS EH and CJS for the web worker EH. A sample is the GH issue notebooks extension: microsoft/vscode-github-issue-notebooks#185 re #130367
lszomoru
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition to ESM modules for Node.js and CommonJS for web workers, replacing Webpack with esbuild for improved performance. Update dependencies and configurations accordingly.