Add initial l10n support #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leverages the new localization support in our VS Code API and engineering pipelines.
Open questions:
I added this in the insiders quality product.json:
https://github.com/microsoft/vscode-distro/blob/distro/quality/insider/product.json#L1314-L1316
but maybe I need to add it to all of them and rev the engine to be higher
in dd2a688 I tried to localize the parser strings as well... but that failed the tests because the unit tests don't have a
vscodeimplementation. Any idea on how I could mock that?