Skip to content

Conversation

@TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Sep 22, 2022

This leverages the new localization support in our VS Code API and engineering pipelines.

Open questions:

  1. I added this in the insiders quality product.json:
    https://github.com/microsoft/vscode-distro/blob/distro/quality/insider/product.json#L1314-L1316
    but maybe I need to add it to all of them and rev the engine to be higher

  2. in dd2a688 I tried to localize the parser strings as well... but that failed the tests because the unit tests don't have a vscode implementation. Any idea on how I could mock that?

@TylerLeonhardt TylerLeonhardt marked this pull request as draft September 22, 2022 18:15
@jrieken
Copy link
Member

jrieken commented Sep 23, 2022

I tried to localize the parser strings as well... but that failed the tests because the unit tests don't have a vscode implementation. Any idea on how I could mock that?

I would keep the parser free of vscode-dependencies. It's a bit of duplication but the LanguageValidation-strategy could have a mapping from ValidationError#code to human-readable messages which are then externalized/translated

@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Sep 23, 2022

I leave the parser strings for the next PR then since we can be iterative here.

@TylerLeonhardt TylerLeonhardt marked this pull request as ready for review September 23, 2022 14:51
@TylerLeonhardt TylerLeonhardt merged commit 6b84827 into main Sep 23, 2022
@TylerLeonhardt TylerLeonhardt deleted the tyler/add-l10n branch September 23, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants