Skip to content

Added support for workingDirectories to the 'lint whole folder' task #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added support for workingDirectories to the 'lint whole folder' task #1861

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35ed0a5
Added support for workingDirectories
mrairdon-midmark Jun 12, 2024
54c28bc
Merge branch 'main' into main
dbaeumer Jun 19, 2024
9eb4369
Merge branch 'main' into main
dbaeumer Jun 20, 2024
c6888e2
Merge branch 'main' into main
dbaeumer Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions client/src/tasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,24 +40,32 @@ class FolderTaskProvider {
return undefined;
}
try {
const command = await findEslint(rootPath);

const kind: EslintTaskDefinition = {
type: 'eslint'
};

const options: vscode.ShellExecutionOptions = { cwd: this.workspaceFolder.uri.fsPath };
const config = vscode.workspace.getConfiguration('eslint', this._workspaceFolder.uri);
const lintTaskOptions= config.get<string>('lintTask.options', '.');

const eslintCommands: string[] = [];
for (const workingDirectory of this.workingDirectories()) {
const eslint = await findEslint(workingDirectory);
eslintCommands.push(`pushd ${workingDirectory} && ${eslint} ${lintTaskOptions} && popd`);
}
return new vscode.Task(
kind, this.workspaceFolder,
'lint whole folder', 'eslint', new vscode.ShellExecution(`${command} ${lintTaskOptions}`, options),
'lint whole folder', 'eslint', new vscode.ShellExecution(eslintCommands.join(' && '), options),
'$eslint-stylish'
);
} catch (error) {
return undefined;
}
}

private workingDirectories() : string []{
return vscode.workspace.getConfiguration('eslint', this._workspaceFolder.uri).get('workingDirectories', undefined) || ['.'];
}
}

/**
Expand Down