respect estlint-suppressions.json

[trickpattyFH20]

There is a new eslint RFC for suppressing violations in an existing codebase: rfc

And a PR that implements it: eslint/eslint#19159

vscode-eslint needs support for this feature

[dbaeumer]

Shouldn't this automatically work when it is implemented in eslint. The extension is based of the eslint npm module so it inherits all features from it.

[trickpattyFH20]

In it's current state, the eslint PR does not work with vscode-eslint. It only supports the eslint-suppressions.json file in the CLI.

Will this only work for the CLI or will it work for the node api as well so that vscode-eslint will respect eslint-suppressions.json? @softius

Thats a good point @trickpattyFH20 I believe this was only briefly mentioned in the RFC and not fully resolved. We could definitely support it by moving part of the logic into the ESLint class and introducing dedicated methods for each action (suppressAll, suppressRules, pruneSuppressions, applySuppressions). That could be handled in a separate PR - which might be preferable given the current state of this one.

Even if it is resolved and moved to the ESLint class, I'm worried what the performance would be like in vscode-eslint considering that any new lint violation in a file that has suppressions would then cause all the suppressed violations to be shown again. @dbaeumer

[dbaeumer]

I am actually not a fan of recoding something in the extension when it is not part of the Node API. This is very hard to keep in sync and up to date. And I am still not sure I understand the RFC. The link provided doesn't point to one. Is it: https://github.com/eslint/rfcs/tree/main/designs/2021-suppression-support