Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small section about editing a profile. #6062

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

laundmo
Copy link
Contributor

@laundmo laundmo commented Feb 22, 2023

Editing profiles by using the normal means of changing settings, modifying extensions etc might see obvious to some but still should be explained somewhere.

This PR is just a small section about this fact, and a note about editing the settings.json directly while switching profiles.

Copy link

@gregvanl gregvanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
The final version of this section may differ slightly after an edit pass.

@gregvanl gregvanl merged commit 706a3f4 into microsoft:profilesTopic Feb 24, 2023
@isidorn
Copy link
Contributor

isidorn commented Feb 24, 2023

@laundmo thank you for the PR and thanks @gregvanl for the review and for pinging me.

@sandy081 can you also review these changes please :) Since the "Note:" part feels like a bug that we can fix?

@sandy081
Copy link
Member

"Note:" makes sense to me. We do not want to auto close and reopen files on switching profiles. This can be unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants