Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Dev Containers topics #5735

Merged
merged 8 commits into from
Oct 26, 2022
Merged

Move Dev Containers topics #5735

merged 8 commits into from
Oct 26, 2022

Conversation

gregvanl
Copy link

No description provided.

Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thanks for taking the time @gregvanl!

Had a few small comments. This also reminded me that I'll need to change references to the vscode-dev-containers repo to the latest repos that are part of the spec. As remaining action items I've added to my backlog:

  • Adjust mentions of vscode-dev-containers
  • Review existing content (largely the containers.md doc) and consider how to restructure (i.e. into smaller docs)

I think both of the above can be done in subsequent PRs.

blogs/2021/06/10/remote-repositories.md Outdated Show resolved Hide resolved
docs/devcontainers/faq.md Outdated Show resolved Hide resolved
docs/devcontainers/faq.md Outdated Show resolved Hide resolved
docs/devcontainers/faq.md Outdated Show resolved Hide resolved
docs/devcontainers/attach-container.md Show resolved Hide resolved
Greg Van Liew and others added 6 commits October 25, 2022 14:06
Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gregvanl gregvanl merged commit 93c888c into main Oct 26, 2022
@gregvanl gregvanl deleted the devConTOC branch October 26, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants