Skip to content

Add IntelliSense configuration property: compilerArgs#3950

Merged
michelleangela merged 10 commits into
masterfrom
mimatias/compiler-args
Aug 6, 2019
Merged

Add IntelliSense configuration property: compilerArgs#3950
michelleangela merged 10 commits into
masterfrom
mimatias/compiler-args

Conversation

@michelleangela
Copy link
Copy Markdown
Contributor

@michelleangela michelleangela commented Jul 19, 2019 •
edited
Loading

  • Add compilerArgs property to IntelliSense configuration
  • When sending configuration to language client, separate any args from compilerPath and add to compilerArgs. The language client from now on expects compilerPath to only have path, and args will be in compilerArgs.
  • Refactor getBuildTasks function to support compilerArgs
  • Update cpp-tools API reference version to 3.0.0

@michelleangela michelleangela requested a review from a team July 19, 2019 22:24
michelleangela
michelleangela commented Jul 19, 2019
View reviewed changes
Comment thread Extension/package.json Outdated
bobbrow
bobbrow requested changes Jul 26, 2019
View reviewed changes
Comment thread Extension/package.json Outdated
Comment thread Extension/src/LanguageServer/configurations.ts Outdated
@michelleangela
Copy link
Copy Markdown
Contributor Author

michelleangela commented Jul 29, 2019

Blocked for check-in until #3987 is merged

@michelleangela michelleangela changed the title [DRAFT] Add new configuration property: compilerArgs Add new configuration property: compilerArgs Jul 30, 2019
@michelleangela michelleangela requested a review from a team July 30, 2019 18:20
@michelleangela michelleangela marked this pull request as ready for review July 30, 2019 18:21
@michelleangela michelleangela changed the title Add new configuration property: compilerArgs Add IntelliSense configuration property: compilerArgs Jul 30, 2019
bobbrow
bobbrow approved these changes Jul 31, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor issues remaining.

Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
@bobbrow bobbrow added this to the August 2019 milestone Jul 31, 2019
@michelleangela michelleangela merged commit b608921 into master Aug 6, 2019
@bobbrow bobbrow deleted the mimatias/compiler-args branch August 8, 2019 16:47
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bobbrow bobbrow bobbrow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.25.0

Development

Successfully merging this pull request may close these issues.

2 participants

@michelleangela @bobbrow