Skip to content

handle speculative requests with the cache #13599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

handle speculative requests with the cache #13599

merged 1 commit into from
May 10, 2025

Conversation

lukka
Copy link
Member

@lukka lukka commented May 9, 2025

No description provided.

@github-project-automation github-project-automation bot moved this to Pull Request in cpptools May 9, 2025
@lukka lukka requested review from benmcmorran, spebl and kuchungmsft May 9, 2025 21:50
@lukka lukka marked this pull request as ready for review May 9, 2025 21:54
@lukka lukka requested a review from a team as a code owner May 9, 2025 21:54
sean-mcmanus
sean-mcmanus requested changes May 9, 2025
View reviewed changes
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected logging: (featureFlag:undefined)result is undefined and no code snippets provided(unknown)

UPDATE: Seems expected. I didn't have "C_Cpp.copilotContextProviderParams" set.

@lukka lukka merged commit 51e5328 into main May 10, 2025
6 checks passed
@lukka lukka deleted the dev/handle-spec-reqs branch May 10, 2025 01:51
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

@benmcmorran benmcmorran Awaiting requested review from benmcmorran

@spebl spebl Awaiting requested review from spebl

@kuchungmsft kuchungmsft Awaiting requested review from kuchungmsft

Assignees
No one assigned
Labels
None yet
Projects
cpptools
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukka @sean-mcmanus