Strip quotes from debug configurations and fix an issue with quotes in paths #12471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
previously approved these changes
Jul 12, 2024
sean-mcmanus
approved these changes
Jul 12, 2024
I'll ask him, but we don't need to block on it since they're not active here. |
sean-mcmanus
approved these changes
Jul 12, 2024
WardenGnaw
approved these changes
Jul 12, 2024
I tested it by modifying the strings directly in TypeScript. It should be the same case as having the localizers put a quote in the translation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address a few CodeQL issues flagged in the repo. There was some code added to escape any double quotes that might be added from the generated debug configurations during the localization process. Since we don't really want those double quotes anyway, it should be acceptable to simply remove them.
While looking at some of the other issues flagged, I noticed that a helper function ends up thinking a quoted path is a relative path. Fixing that doesn't fix any other underlying assumptions we make about the include paths set by the user, but it does allow them to be squiggled when the true path is invalid.