Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip quotes from debug configurations and fix an issue with quotes in paths #12471

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Jul 12, 2024

This should address a few CodeQL issues flagged in the repo. There was some code added to escape any double quotes that might be added from the generated debug configurations during the localization process. Since we don't really want those double quotes anyway, it should be acceptable to simply remove them.

While looking at some of the other issues flagged, I noticed that a helper function ends up thinking a quoted path is a relative path. Fixing that doesn't fix any other underlying assumptions we make about the include paths set by the user, but it does allow them to be squiggled when the true path is invalid.

sean-mcmanus
sean-mcmanus previously approved these changes Jul 12, 2024
Copy link
Collaborator

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get @WardenGnaw to approve too?

@bobbrow
Copy link
Member Author

bobbrow commented Jul 12, 2024

Can you get @WardenGnaw to approve too?

I'll ask him, but we don't need to block on it since they're not active here.

@WardenGnaw
Copy link
Member

It looks like these changes came from this commit: b82a86e

Which was to fix #4526

I would do a quick validation in a German VS Code to ensure the debug configuration is still being generated properly.

@bobbrow
Copy link
Member Author

bobbrow commented Jul 12, 2024

It looks like these changes came from this commit: b82a86e

Which was to fix #4526

I would do a quick validation in a German VS Code to ensure the debug configuration is still being generated properly.

I tested it by modifying the strings directly in TypeScript. It should be the same case as having the localizers put a quote in the translation.

@bobbrow bobbrow merged commit 6fc0529 into main Jul 12, 2024
4 checks passed
@bobbrow bobbrow deleted the bobbrow/quotes branch July 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants