Fix memory leak in CapturingToken correlation map#3475
Merged
zhichli merged 2 commits intozhichli/fixExportfrom Feb 5, 2026
Merged
Fix memory leak in CapturingToken correlation map#3475zhichli merged 2 commits intozhichli/fixExportfrom
zhichli merged 2 commits intozhichli/fixExportfrom
Conversation
Add finally block to ensure correlation ID is cleaned up from the capturingTokenCorrelationMap even when requests fail before reaching BYOK providers. This prevents memory leaks when: - languageModel.sendRequest throws immediately - The model is not a BYOK provider - Any other failure occurs before BYOK provider retrieval The retrieveCapturingTokenByCorrelation call is idempotent - if BYOK providers already retrieved the token, this will return undefined. Co-authored-by: zhichli <57812115+zhichli@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on BYOK request logging improvements
Fix memory leak in CapturingToken correlation map
Feb 5, 2026
zhichli
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
capturingTokenCorrelationMapwas leaking entries when requests failed before reaching BYOK providers or when non-BYOK models were used.Changes
finallyblock inExtensionContributedChatEndpoint.makeChatRequest2()to ensure correlation map cleanup in all code pathsundefinedAddresses feedback from #3474: #3474 (comment)
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.