Add azure open ai support to simulator model config #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
reviewed
Jul 23, 2025
lramos15
reviewed
Jul 23, 2025
| @@ -105,26 +107,40 @@ export class OpenAICompatibleTestEndpoint extends ChatEndpoint { | |||
| throw new Error(`API key environment variable ${this.modelConfig.apiKeyEnvName} is not set`); | |||
| } | |||
|
|
|||
| if (this.modelConfig.type === 'azureOpenai') { | |||
There was a problem hiding this comment.
Should this be in a separate azure endpoint? Just in case they continue to diverge? Maybe via na override. You can see BYOK does this
There was a problem hiding this comment.
what do you mean by na override?
I was on the side of keeping it all in one, and create a separate azure endpoint if it diverges a lot. I'm still unsure of how much more if-elsing is going to be needed to be able to know the right separations (probably will have more knowledge as we continue to try more types of models).
lramos15
approved these changes
Jul 24, 2025
rzhao271
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.