Linux: Add support for snaps of CMake

[Zingam]

I have just installed Ubuntu 19.10 and used the Software installer application to install Visual Studio Code and CMake 3.15. I cloned my repository from GitHub and whenever I try to call CMake configure in Visual Studio code I get an error message: Bad CMake executable /snap/bin/cmake. CMake seems to run fine in a terminal.

VS Code/CMake extension used to run just fine out-of-the-box in previous version of Ubuntu.

When I try to enter the path manually I get error messages like these:

[rollbar] Unhandled exception: Unhandled Promise rejection: configure TypeError: Cannot read property 'on' of undefined {}
[rollbar] Unhandled exception: Error during CMake upgrade TypeError: Cannot read property 'on' of undefined {"version":"3.13.2","linuxURL":"https://github.com/Kitware/CMake/releases/download/v3.13.2/cmake-3.13.2-Linux-x86_64.sh","windowsURL":"https://github.com/Kitware/CMake/releases/download/v3.13.2/cmake-3.13.2-win64-x64.msi"}

Actually /snap/bin/cmake is not an executable but a link if I recall correctly.

[bobbrow]

A link should be ok. In your case the extension is running /snap/bin/cmake --version and inspecting the output to check if the executable is ok. Can you run that command and let me know what it prints out in your terminal?

The "unhandled exception" error is unrelated to this and should be gone in 1.2.0 (unreleased).

[Zingam]

Ubuntu Terminal:

~$ /snap/bin/cmake --version
cmake version 3.15.4

CMake` suite maintained and supported by Kitware (kitware.com/cmake).

VSCode Terminal:

~/Projects/GitHub/GunBox/GunBox$ ~$ /snap/bin/cmake --version
~$: command not found
~/Projects/GitHub/GunBox/GunBox$ cmake version 3.15.4
CMake Error: The source directory "/home/hristo/Projects/GitHub/GunBox/GunBox/3.15.4" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
/Projects/GitHub/GunBox/GunBox$
~/Projects/GitHub/GunBox/GunBox$ CMake suite maintained and supported by Kitware (kitware.com/cmake).
bash: syntax error near unexpected token `('
~/Projects/GitHub/GunBox/GunBox$

I removed the PC name

[Zingam]

This command also appears to execute properly: /snap/bin/cmake -E server --experimental

[Zingam]

@bobbrow Will version 1.2 be released soon?

[bobbrow]

Yes. Should be early next week. We're doing some final testing.

[Zingam]

OK. Thanks! I'll wait to see how version 1.2 will behave as the currently released doesn't work for me neither on latest Ubuntu nor Windows with the latest MSVC, CMake, GCC, etc. All of which worked before.

[hheld]

It works when you use /snap/cmake/current/bin/cmake as CMake Path. All snap executables seem to be just symbolic links to /usr/bin/snap, and that seems to work fine when called from a terminal but apparently not from the CMake extension in VSCode ...

[Zingam]

@hheld Thank you for the advice. I'll try that. I tried setting this manually before but maybe I didn't set the proper path.

[Zingam]

There are two entries related to CMake Path. Which one is the correct one:

Cmake: Cmake Path
Name/path of the CMake executable to use
cmake
Cmake: Ctest Path
Path to CTest executable. If null, will be inference from cmake.cmakePath (recommended to leave null)
Cmake: Cmake Path
The path to CMake generator executable

@hheld Setting /snap/cmake/current/bin/cmake did the job!

Thank you!

I also have the twxs's extension (which I hope will be absorbed into CMake Tools) but I don't think that it is causing that duplication.

[Zingam]

@bobbrow Maybe this issue's title should be changed and filed as a bug: "CMake Tools" don't work with symbolic links on Linux?

[hheld]

I don't think this issue has anything to do with symbolic links. I don't really know the mechanics of how snap apps work, but I guess something must transform a call to /snap/bin/cmake to something like snap run cmake -- and I guess this doesn't happen when called from the VSCode extension. The link simply points to /usr/bin/snap and this isn't cmake.