Changes to the msbuild signing project to remove unwanted files #622
Conversation
| $(OutDir)node_modules\resolve\test\resolver\mug.js; | ||
| $(OutDir)node_modules\resolve\test\pathfilter\deep_ref\main.js; | ||
| $(OutDir)node_modules\resolve\test\resolver\baz\doom.js; | ||
| $(OutDir)node_modules\vsce\node_modules\tmp\test\symlinkme\file.js; |
There was a problem hiding this comment.
I'm curious where this list of node_modules comes from?
There was a problem hiding this comment.
That's really the list of files that cause the signing step to fail...but interestingly, they cause the signing step to fail because they are empty JS files (and apparently the signing tool refuses to append our Authenticode cert block to an empty *.js file).
I think we've found a way to simplify some of this process, so hopefully we'll be able to remove that exclusion list in the near future.
There was a problem hiding this comment.
These all appear to be devDependencies, which don't need to be shipped. I would recommend not shipping any devDependencies, it will make the released version much smaller!
There was a problem hiding this comment.
Indeed. One of the effects of our planned simplification change will be to not copy/sign/package/ship devDependencies. Thanks Rob!
Removes the dll, pdb, and zip files, which we don't want in the published NuGet package.