azure-pipelines: Allow a repository to specify additional setup steps #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now any repository consuming these templates can customize how their repository is build, tested, and published by changing the behavior of 'npm run build', test, etc. But if you need some additional setup tasks that don't cleanly fit into npm then it's tough to do. The specific motivation for this change is wanting to use Nerdbank.GitVersioning to update our Azure DevOps build numbers to match what it's computing in an internal repository consuming these templates. The support for that though requires installing a .NET based tool onto the machine, which means we need to ensure .NET is installed on the machine. Rather than reinventing that, it'd be best to use the existing Azure DevOps task which already handles that. The alternative approaches here would be to: 1. Just have the templates always install .NET, but that's just a waste of time for other repositories. 2. Add a specific setting to enable installing .NET, but rather than creating a one-off feature, it's just as easy to make a general mechanism. 3. Stop having the other repository consume these templates at all.
jasonmalinowski
force-pushed
the
allow-additional-setup-steps
branch
from
fcee634
to
8c7b7c2
Compare
bwateratmsft
approved these changes
Aug 22, 2024
bwateratmsft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now any repository consuming these templates can customize how their repository is build, tested, and published by changing the behavior of 'npm run build', test, etc. But if you need some additional setup tasks that don't cleanly fit into npm then it's tough to do.
The specific motivation for this change is wanting to use Nerdbank.GitVersioning to update our Azure DevOps build numbers to match what it's computing in an internal repository consuming these templates. The support for that though requires installing a .NET based tool onto the machine, which means we need to ensure .NET is installed on the machine. Rather than reinventing that, it'd be best to use the existing Azure DevOps task which already handles that.
The alternative approaches here would be to: