Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: Add stashReadOnlyContentSync function #1769

Merged
merged 4 commits into from
Aug 14, 2024
Merged

utils: Add stashReadOnlyContentSync function #1769

merged 4 commits into from
Aug 14, 2024

Conversation

JasonYeMSFT
Copy link
Contributor

Add a stashReadOnlyContentSync function so it can be used in scenarios where asynchronous functions cannot be used.

@JasonYeMSFT JasonYeMSFT requested a review from a team as a code owner August 14, 2024 17:22
bwateratmsft
bwateratmsft previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well update the package.json and package-lock.json package versions too.

nturinski
nturinski previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to update the index.d.ts file as well. I think the index.ts already exports the entire file.

bwateratmsft
bwateratmsft previously approved these changes Aug 14, 2024
View reviewed changes
@JasonYeMSFT JasonYeMSFT merged commit b010f00 into main Aug 14, 2024
4 checks passed
@JasonYeMSFT JasonYeMSFT deleted the dev/chuye/add-stashReadOnlyContentSync branch August 14, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nturinski nturinski nturinski approved these changes

@bwateratmsft bwateratmsft bwateratmsft left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonYeMSFT @nturinski @bwateratmsft