Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Don't require configureBeforePrompt to return a promise #1759

Merged
merged 12 commits into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1293,7 +1293,7 @@ export declare abstract class AzureWizardPromptStep<T extends IActionContext> {
* Can be used to optionally configure the wizard context before determining if prompting is required
* This method will be called before `shouldPrompt`
*/
public configureBeforePrompt?(wizardContext: T): Promise<void>;
public configureBeforePrompt?(wizardContext: T): void | Promise<void>;

/**
* Return true if this step should prompt based on the current state of the wizardContext
Expand Down
2 changes: 1 addition & 1 deletion utils/src/wizard/AzureWizardPromptStep.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export abstract class AzureWizardPromptStep<T extends types.IActionContext> impl
public getSubWizard?(wizardContext: T): Promise<types.IWizardOptions<T> | undefined>;
public undo?(wizardContext: T): void;

public configureBeforePrompt?(wizardContext: T): Promise<void>;
public configureBeforePrompt?(wizardContext: T): void | Promise<void>;
public abstract shouldPrompt(wizardContext: T): boolean;

public reset(): void {
Expand Down
Loading