appservice: Fix containerized function app name validation to exclude uppercase letters #1754
Conversation
| @@ -113,6 +113,8 @@ export class SiteNameStep extends AzureNameStep<SiteNameStepWizardContext> { | |||
|
|
|||
| if (name.length < siteNamingRules.minLength || name.length > siteNamingRules.maxLength) { | |||
| return vscode.l10n.t('The name must be between {0} and {1} characters.', siteNamingRules.minLength, siteNamingRules.maxLength); | |||
| } else if ((!/^[a-z]([-a-z0-9]*[a-z0-9])?$/.test(name)) && this._siteFor === "containerizedFunctionApp") { | |||
There was a problem hiding this comment.
nit: You should check the siteFor property first so the conditional can just abort if it's not a containerized app. It's probably small, but still a wasted check.
| @@ -113,6 +113,8 @@ export class SiteNameStep extends AzureNameStep<SiteNameStepWizardContext> { | |||
|
|
|||
| if (name.length < siteNamingRules.minLength || name.length > siteNamingRules.maxLength) { | |||
| return vscode.l10n.t('The name must be between {0} and {1} characters.', siteNamingRules.minLength, siteNamingRules.maxLength); | |||
| } else if (this._siteFor === "containerizedFunctionApp" && (!/^[a-z]([-a-z0-9]*[a-z0-9])?$/.test(name))) { | |||
There was a problem hiding this comment.
I think the * here might be in the wrong spot, otherwise you can still have multiple -'s together. Here is what I think you had for ContainerAppNameStep!
!/^[a-z][a-z0-9]*(-[a-z0-9]+)*$/.test(name)
There was a problem hiding this comment.
Oh lol yes I copied this from ManagedEnvironmentNameStep since I figured it was the same since the error message was the same but I can change it.
On another note shouldn't the regex be the same between ContainerAppNameStep and ManagedEnvironmentNameStep since the error message is the same between the two?
There was a problem hiding this comment.
Yeah good catch, if the requirements are the same I think we should update that check logic
This is what the name validation on the portal now says:
It matches the validation from container apps so using the regular expression from there.