-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils: Add implementation for showWorkspaceFolderPick
#1734
Conversation
showWorkspaceFolderPick
to AzExtUserInput
showWorkspaceFolderPick
…into mwf/showWorkspaceFolderPick
f65eda8
to
a2cf8b8
Compare
* @throws `UserCancelledError` if the user cancels. | ||
* @returns A promise that resolves to the selected `WorkspaceFolder`. | ||
*/ | ||
showWorkspaceFolderPick(options: AzExtWorkspaceFolderPickOptions): Promise<WorkspaceFolder>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make more sense to name it showWorkspaceFolderPicker
? Is it a pick or a picker? This is a nit, I'm mostly asking and not asking for a change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Picker is potentially a better name, but I was thinking to just keep the name mirrored with its VS Code analogue => vscode.window.showWorkspaceFolderPick
Depends on publishing the
dev
package first, see this