Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding staged support for MongoClusters #894

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

tnaum-ms
Copy link
Contributor

@tnaum-ms tnaum-ms commented Aug 8, 2024

In an upcoming release, vscode-databases will add support for MongoClusters. Once this new feature is available, a custom field will be included in the package.json of vscode-databases. This field will serve as a switch to enable or disable MongoClusters support.

The motivation behind this approach is to avoid advertising MongoCluster nodes prematurely while we work on the public release of the vscode-extension.

Once MongoClusters support is officially released, we will remove the staging code.

@tnaum-ms tnaum-ms requested a review from a team as a code owner August 8, 2024 11:01
@tnaum-ms
Copy link
Contributor Author

tnaum-ms commented Aug 8, 2024

I forgot / missed the squash option..

Copy link
Member

@alexweininger alexweininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Once merged I can bump the api package version to "2.4.0" and release.

@alexweininger alexweininger merged commit 90bdfa3 into microsoft:main Aug 19, 2024
3 checks passed
@microsoft microsoft locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants