-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maintainCloudShellConnection command #836
Conversation
} | ||
|
||
export async function maintainCloudShellConnection(_context: IActionContext, options: MaintainCloudShellConnectionOptions) { | ||
while (true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of have an aversion to while(true)
loops for some reason. While I do prefer a recursive setTimeout
method, I couldn't find anything really definitive about whether infinite while loops are riskier or not so feel free to keep it this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have an aversion to while(true)
. I might change it if I get around to it.
Added the maintain cloud shell connection command, which is only to be called by vscode.dev. And isn't shown in the palette.