Add maintainCloudShellConnection command #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
reviewed
Apr 10, 2024
| } | ||
|
|
||
| export async function maintainCloudShellConnection(_context: IActionContext, options: MaintainCloudShellConnectionOptions) { | ||
| while (true) { |
There was a problem hiding this comment.
I kind of have an aversion to while(true) loops for some reason. While I do prefer a recursive setTimeout method, I couldn't find anything really definitive about whether infinite while loops are riskier or not so feel free to keep it this way.
There was a problem hiding this comment.
I also have an aversion to while(true). I might change it if I get around to it.
nturinski
approved these changes
Apr 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the maintain cloud shell connection command, which is only to be called by vscode.dev. And isn't shown in the palette.