Use Uri.fspath as key for FuncRunningMap/Port #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies pickFuncProcess startFuncProcessFromApi removing the workspaceFolder requirement and adding in the environment variables. funcHostTask was originally tracked by vscode.WorkspaceFolder via Task.Scope and DebugConfiguration.WorkspaceFolder. This commit modifies it to use a new AzureFunctionTaskDefinition.functionsApp property which is either the `buildPath` from startFuncProcessFromApi or the vscode.WorkspaceFolder.uri.fsPath to maintain backwards compatibility. runningFuncTaskMap, funcTaskStartedEmitter, and runningFuncPortMap now all using the vscode.Uri.fsPath string which can be used to map back to a WorkspaceFolder. However in the cases the WorkspaceFolder fails, APIs that used it will now see undefined passed in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies pickFuncProcess startFuncProcessFromApi removing the workspaceFolder requirement and adding in the environment variables.
funcHostTask was originally tracked by vscode.WorkspaceFolder via Task.Scope and DebugConfiguration.WorkspaceFolder. This commit modifies it to use a new AzureFunctionTaskDefinition.functionsApp property which is either the
buildPathfrom startFuncProcessFromApi or the vscode.WorkspaceFolder.uri.fsPath to maintain backwards compatibility.runningFuncTaskMap, funcTaskStartedEmitter, and runningFuncPortMap now all using the vscode.Uri.fsPath string which can be used to map back to a WorkspaceFolder. However in the cases the WorkspaceFolder fails, APIs that used it will now see undefined passed in.