Reduce AsyncLazy value factory retention to improve GC-test stability#1552
Merged
Reduce AsyncLazy value factory retention to improve GC-test stability#1552
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces the retention time of the value factory delegate in AsyncLazy<T> to improve garbage collection behavior and test stability. The change introduces early nulling of captured variables to allow the GC to reclaim memory sooner.
Changes:
- Adds
localValueFactoryvariable to store the value factory reference before nulling the capturedoriginalValueFactory - Nulls
originalValueFactoryimmediately after copying it to reduce closure retention - Nulls
localValueFactoryin the finally block to ensure cleanup after the factory executes
sandyarmstrong
approved these changes
Feb 26, 2026
Member
sandyarmstrong
left a comment
sandyarmstrong
left a comment
There was a problem hiding this comment.
I'm surprised this makes such a difference in GC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.