Avoid VSTHRD003 diagnostic for properties on objects created by async methods - #1263
Merged
Merged
Conversation
… methods We already avoided such cases when the creating method was synchronous, but we missed the async case. This came up when trying to update the analyzers version used by the VS repo.
Andrew Arnott (AArnott)
requested review from
Bertan Aygun (BertanAygun) and
Lifeng Lu (lifengl)
November 22, 2023 19:42
Andrew Arnott (AArnott)
enabled auto-merge
November 22, 2023 19:42
Bertan Aygun (BertanAygun)
approved these changes
Nov 22, 2023
This was referenced Aug 7, 2025
This was referenced Jun 17, 2026
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already avoided such cases when the creating method was synchronous, but we missed the async case. This came up when trying to update the analyzers version used by the VS repo.