Fix disposal of marshalable object proxies#1156
Merged
Merged
Conversation
AArnott
approved these changes
Feb 25, 2025
Member
AArnott
left a comment
There was a problem hiding this comment.
This looks good to me. Is the theory of the bug then that DisposeAsync was being called concurrently?
Member
Author
|
@AArnott, The sample has a loop of the following: await using var stream = new NamedPipeClientStream(".", "TestPipe", PipeDirection.InOut, PipeOptions.Asynchronous);
await stream.ConnectAsync().ConfigureAwait(false);
using var jsonRpc = JsonRpc.Attach(stream);
var serverProxy = jsonRpc.Attach<IServer>();
using var myService = await serverProxy.GetMyService().ConfigureAwait(false);
await myService.DoSomething().ConfigureAwait(false);Which results in frequent exceptions on the following line, due to the collection having been modified concurrently with the iteration foreach (object target in this.localTargetObjectsToDispose)I verified that the issue doesn't repro anymore after my change. I believe that the cause of the concurrent change of the collection is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #1087