Skip to content

[faiss] Add required OpenMP dependency#52620

Draft
SunBlack wants to merge 2 commits into
microsoft:masterfrom
SunBlack:faiss
Draft

[faiss] Add required OpenMP dependency#52620
SunBlack wants to merge 2 commits into
microsoft:masterfrom
SunBlack:faiss

Conversation

@SunBlack

@SunBlack SunBlack commented Jun 27, 2026

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

The CI failed in #52616, due to

CMake Error at /Users/vcpkg/Data/work/1/s/downloads/tools/cmake-4.3.3-osx/cmake-4.3.3-macos-universal/CMake.app/Contents/share/cmake-4.3/Modules/FindPackageHandleStandardArgs.cmake:290 (message):
  Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)
Call Stack (most recent call first):
  /Users/vcpkg/Data/work/1/s/downloads/tools/cmake-4.3.3-osx/cmake-4.3.3-macos-universal/CMake.app/Contents/share/cmake-4.3/Modules/FindPackageHandleStandardArgs.cmake:654 (_FPHSA_FAILURE_MESSAGE)
  /Users/vcpkg/Data/work/1/s/downloads/tools/cmake-4.3.3-osx/cmake-4.3.3-macos-universal/CMake.app/Contents/share/cmake-4.3/Modules/FindOpenMP.cmake:734 (find_package_handle_standard_args)
  /Users/vcpkg/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:939 (_find_package)
  faiss/CMakeLists.txt:696 (find_package)

Draft to verify the issue first with a forces rebuild due to changed port-version.

@SunBlack SunBlack changed the title Add required OpenMP dependency [faiss] Add required OpenMP dependency Jun 27, 2026
@BillyONeal

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dg0yt

dg0yt commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The CI failed in #52616, due to

CMake Error at /Users/vcpkg/Data/work/1/s/downloads/tools/cmake-4.3.3-osx/cmake-4.3.3-macos-universal/CMake.app/Contents/share/cmake-4.3/Modules/FindPackageHandleStandardArgs.cmake:290 (message):
  Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)
Call Stack (most recent call first):
  /Users/vcpkg/Data/work/1/s/downloads/tools/cmake-4.3.3-osx/cmake-4.3.3-macos-universal/CMake.app/Contents/share/cmake-4.3/Modules/FindPackageHandleStandardArgs.cmake:654 (_FPHSA_FAILURE_MESSAGE)
  /Users/vcpkg/Data/work/1/s/downloads/tools/cmake-4.3.3-osx/cmake-4.3.3-macos-universal/CMake.app/Contents/share/cmake-4.3/Modules/FindOpenMP.cmake:734 (find_package_handle_standard_args)
  /Users/vcpkg/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:939 (_find_package)
  faiss/CMakeLists.txt:696 (find_package)

faiss is an expected failure in vcpkg CI for osx, due to the Apple toolchain lacking OpenMP support. Probably the CI failed for a different reason, but a log is not available.

@SunBlack

Copy link
Copy Markdown
Contributor Author

Probably the CI failed for a different reason, but a log is not available.

I still have the CI log archive locally, in case you want to take a look (faiss, octave, and qtdeclarative failed there). I initially only checked faiss, and what’s interesting is that it requires OpenMP but doesn’t define it as a direct dependency, so I wanted to test whether adding that might fix the issue. What was interesting, though, was this: Simply increasing the port version to trigger a rebuild didn't cause the CI to fail. But rebashing it against the sqlite3 commit did. Since it seems to be running through again now, I’m considering whether to just close this test or to explicitly add OpenMP after all. Do you have any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants