Skip to content

[quickfix] Remove vendored double-conversion#52056

Merged
BillyONeal merged 3 commits into
microsoft:masterfrom
vicroms:ci/fix-quickswitch
May 28, 2026
Merged

[quickfix] Remove vendored double-conversion#52056
BillyONeal merged 3 commits into
microsoft:masterfrom
vicroms:ci/fix-quickswitch

Conversation

@vicroms
Copy link
Copy Markdown
Member

@vicroms vicroms commented May 27, 2026

Fix CI failures

BillyONeal
BillyONeal previously approved these changes May 27, 2026
@@ -0,0 +1,79 @@
diff --git a/src/C++/CMakeLists.txt b/src/C++/CMakeLists.txt
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parts of this patch that came from fix-build.patch don't appear to be about devendoring double-conversion. Since it fixes a baseline issue and this does avoid patches on patches, not going to request changes over this.

Comment thread ports/quickfix/portfile.cmake Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Quickfix is failing in CI because it includes vendored double-conversion .cc files that conflict with system/upstream versions. This PR devendors double-conversion, adding it as an explicit vcpkg dependency, replacing the previous build-fix patch with a combined patch, and wiring the dependency into the installed CMake config.

Changes:

  • Replace 00001-fix-build.patch with 00001-devendor-double-conversion.patch that links against double-conversion::double-conversion and removes vendored .cc includes.
  • Add double-conversion to dependencies and prepend find_dependency(double-conversion CONFIG) to the installed quickfix-config.cmake.
  • Bump port-version to 1 and update the versions database.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ports/quickfix/vcpkg.json Adds double-conversion dep and bumps port-version.
ports/quickfix/portfile.cmake Switches patch reference; injects find_dependency into the installed config.
ports/quickfix/00001-fix-build.patch Removed; superseded by the new combined patch.
ports/quickfix/00001-devendor-double-conversion.patch New patch combining build fixes and devendoring of double-conversion.
versions/baseline.json Bumps quickfix baseline port-version to 1.
versions/q-/quickfix.json Adds new version entry with updated git-tree.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Billy O'Neal <bion@microsoft.com>
@BillyONeal BillyONeal merged commit 216bb69 into microsoft:master May 28, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants