[quickfix] Remove vendored double-conversion#52056
Conversation
| @@ -0,0 +1,79 @@ | |||
| diff --git a/src/C++/CMakeLists.txt b/src/C++/CMakeLists.txt | |||
There was a problem hiding this comment.
The parts of this patch that came from fix-build.patch don't appear to be about devendoring double-conversion. Since it fixes a baseline issue and this does avoid patches on patches, not going to request changes over this.
There was a problem hiding this comment.
Pull request overview
Quickfix is failing in CI because it includes vendored double-conversion .cc files that conflict with system/upstream versions. This PR devendors double-conversion, adding it as an explicit vcpkg dependency, replacing the previous build-fix patch with a combined patch, and wiring the dependency into the installed CMake config.
Changes:
- Replace
00001-fix-build.patchwith00001-devendor-double-conversion.patchthat links againstdouble-conversion::double-conversionand removes vendored.ccincludes. - Add
double-conversionto dependencies and prependfind_dependency(double-conversion CONFIG)to the installedquickfix-config.cmake. - Bump
port-versionto 1 and update the versions database.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ports/quickfix/vcpkg.json | Adds double-conversion dep and bumps port-version. |
| ports/quickfix/portfile.cmake | Switches patch reference; injects find_dependency into the installed config. |
| ports/quickfix/00001-fix-build.patch | Removed; superseded by the new combined patch. |
| ports/quickfix/00001-devendor-double-conversion.patch | New patch combining build fixes and devendoring of double-conversion. |
| versions/baseline.json | Bumps quickfix baseline port-version to 1. |
| versions/q-/quickfix.json | Adds new version entry with updated git-tree. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Billy O'Neal <bion@microsoft.com>
Fix CI failures