[luminoengine] Avoid naming stdext::checked_array_iterator. - #51785
Merged
Victor Romero (vicroms) merged 1 commit intoMay 15, 2026
Merged
Conversation
Also fixes microsoft#29879 to actually hook up LUMINO_BUILD_ENGINE in the generated configs (it was missing @s) See also: LuminoEngine/Lumino#221 See also: LuminoEngine/Lumino#222 See also: LuminoEngine/Lumino#223
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the luminoengine port to fix build/config issues with newer MSVC (19.51 / VS 2026) and corrects how the generated CMake package config reflects whether the optional engine feature was built.
Changes:
- Add a patch to avoid using
stdext::checked_array_iteratoron MSVC 19.51+ under_SECURE_SCL. - Fix
LuminoConfig.cmake.insoLUMINO_BUILD_ENGINEis substituted at configure time (via@...@) and the umbrella target only linksLuminoEnginewhen it was built. - Bump
port-versionto 2, update version database entries, and add a CI feature baseline entry forluminoengine[engine].
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| versions/l-/luminoengine.json | Adds the new 0.10.1#2 version entry (new git-tree). |
| versions/baseline.json | Updates baseline to luminoengine port-version 2. |
| scripts/ci.feature.baseline.txt | Marks luminoengine[engine] as feature-failing (links upstream issue). |
| ports/luminoengine/vcpkg.json | Bumps port-version to 2. |
| ports/luminoengine/portfile.cmake | Adds the new MSVC patch and updates patch references/comments. |
| ports/luminoengine/fix-cmake-config.patch | Updates installed config logic to link LuminoEngine conditionally using @LUMINO_BUILD_ENGINE@. |
| ports/luminoengine/avoid-stdext-checked-array-iterator.patch | Avoids checked iterator typedef on MSVC 19.51+ to address the reported build issue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Victor Romero (vicroms)
approved these changes
May 15, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Visual Studio 2026 18.6.0 / MSVC 19.51.
Also fixes #29879 to actually hook up LUMINO_BUILD_ENGINE in the generated configs (it was missing
@s)See also: LuminoEngine/Lumino#221
See also: LuminoEngine/Lumino#222
See also: LuminoEngine/Lumino#223