[ezfoundation] Disable /WX - #51748
Merged
Billy O'Neal (BillyONeal) merged 1 commit intoMay 14, 2026
Merged
Conversation
``` \Code\Engine\Foundation/Types/Implementation/VariantHelper_inl.h(16): error C2220: the following warning is treated as an error \Code\Engine\Foundation/Types/Implementation/VariantHelper_inl.h(16): warning C4864: expected 'template' keyword before dependent template name \Code\Engine\Foundation/Types/Implementation/VariantHelper_inl.h(16): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings ```
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ezfoundation port to stop treating compiler warnings as errors, addressing new warnings surfaced by the Visual Studio 2026 toolset in vcpkg’s build infrastructure.
Changes:
- Bump
ezfoundationtoport-version: 1and update the baseline/versions entries accordingly. - Update the portfile to apply a new patch that removes
/WX(and equivalent “warnings-as-errors” flags) from ezEngine’s build scripts. - Minor cleanup/normalization in the existing vcpkg patch file.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| versions/e-/ezfoundation.json | Adds a new port-version: 1 entry for 21.10. |
| versions/baseline.json | Updates ezfoundation baseline to port-version: 1. |
| ports/ezfoundation/vcpkg.json | Bumps port-version to 1. |
| ports/ezfoundation/portfile.cmake | Switches patch set to include the new “disable warnings-as-errors” patch. |
| ports/ezfoundation/ezfoundation-vcpkg.diff | Small patch adjustments (including build-info header formatting). |
| ports/ezfoundation/disable-warnings-as-errors.diff | New patch that removes /WX and similar “warnings-as-errors” flags across multiple upstream build files. |
Comments suppressed due to low confidence (1)
ports/ezfoundation/disable-warnings-as-errors.diff:20
- After removing the
target_compile_options(... -Werror=...)line, thisif(NOT ... ThirdParty)branch becomes empty while theelse()still applies-Wno-everything. Consider inverting the condition or rewriting the block to avoid an empty branch in the patched upstream CMake (it’s harder to read and maintain as-is).
if(NOT (CMAKE_CURRENT_SOURCE_DIR MATCHES "Code/ThirdParty"))
- target_compile_options(${TARGET_NAME} PRIVATE -Werror=inconsistent-missing-override -Werror=switch -Werror=uninitialized)
else()
# Ignore all warnings in third party code.
target_compile_options(${TARGET_NAME} PRIVATE -Wno-everything)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Victor Romero (vicroms)
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of May Patch Tuesday we are updating vcpkg's build lab to Visual Studio 2026 resulting in new warnings like: