[cppwinrt] Guard add_library to avoid "another target with the same name already exists" CMake error
#49767
Conversation
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
Sorry, it is not your fault, apart from theCPPWINRT_TOOL item. I just comment what I see.
|
|
||
| set(_cppwinrt_exe "${_cppwinrt_root}/@tool_path@") | ||
| if (EXISTS "${_cppwinrt_exe}") | ||
| if (NOT TARGET Microsoft::CppWinRT) |
There was a problem hiding this comment.
Guarding add_library is right, but
| else() | ||
|
|
||
| set(cppwinrt_FOUND FALSE) | ||
| if (EXISTS "${_cppwinrt_exe}") |
There was a problem hiding this comment.
This check is pointless. The executable is always installed by the port.
There was a problem hiding this comment.
Agreed, but I would like to leave the number of changes I'm making minimal
| ) | ||
|
|
||
| set(cppwinrt_FOUND TRUE) | ||
| set(CPPWINRT_TOOL ${_cppwinrt_exe}) |
There was a problem hiding this comment.
It must always set CPPWINRT_TOOL in the local scope, regardless of the library target.
There was a problem hiding this comment.
Could you elaborate why please?
| INTERFACE_LINK_LIBRARIES "${_cppwinrt_root}/lib/@lib_name@" | ||
| ) | ||
|
|
||
| set(cppwinrt_FOUND TRUE) |
There was a problem hiding this comment.
This is handled by CMake if the call is spelled find_package(cppwinrt ...).
|
|
||
| else() | ||
|
|
||
| set(cppwinrt_FOUND FALSE) |
There was a problem hiding this comment.
This can't happen when lib and exe are installed.
This comment was marked as resolved.
This comment was marked as resolved.
2 participants
Fixes #49720.
Guards the
add_librarycall so that consumers of the package can callfind_packagewithout needing to guard to avoid the CMake build: