[libversion] Rename version.lib. #48176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies repology/libversion#40 as a patch. See Windows SDK conflict from new port: microsoft#48066 Under https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#do-not-rename-binaries-outside-the-names-given-by-upstream I want to give upstream a chance to merge this.
BillyONeal
added
the
category:port-bug
dg0yt
reviewed
Nov 7, 2025
| + | ||
| +if(WIN32) | ||
| + # avoid clash with version.lib from the Windows SDK and the dynamic target above | ||
| + set(LIBVERSION_STATIC_OUTPUT_NAME libversion_static) |
Contributor
There was a problem hiding this comment.
Adding a third variant of the name?
And of course mingw will get some variants of liblibversion...
Member
Author
There was a problem hiding this comment.
I would be happy to pick something else; is there an existing name variant that doesn't create problems?
It can't be just "libversion" or the dynamic version above will conflict
Member
Author
|
Upstream explicitly rejected this so we can't merge it. |
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Nov 10, 2025
See discussion: * repology/libversion#40 * microsoft#48176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies repology/libversion#40 as a patch.
See Windows SDK conflict from new port: #48066
Under https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#do-not-rename-binaries-outside-the-names-given-by-upstream I want to give upstream a chance to merge this.
Thanks for figuring out the problem @dg0yt !