Skip to content

Conversation

@oleg-derevenetz
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@BillyONeal BillyONeal merged commit 16852ae into microsoft:master Sep 3, 2025
18 checks passed
@oleg-derevenetz oleg-derevenetz deleted the sdl2-2.32.10 branch September 4, 2025 06:13
@BillyONeal
Copy link
Member

Looks like this may have caused some regressions in other ports, total guess on my part so far:

SDL2-staticd.lib(SDL_windowskeyboard.c.obj) : error LNK2019: unresolved external symbol GetFileVersionInfoSizeA referenced in function IME_GetId
SDL2-staticd.lib(SDL_windowskeyboard.c.obj) : error LNK2019: unresolved external symbol GetFileVersionInfoA referenced in function IME_GetId
SDL2-staticd.lib(SDL_windowskeyboard.c.obj) : error LNK2019: unresolved external symbol VerQueryValueA referenced in function IME_GetId

@BillyONeal
Copy link
Member

That said libsdl-org/SDL@release-2.32.8...release-2.32.10 does not have obvious causes of that :/

@BillyONeal
Copy link
Member

Hmmm maybe not. Maybe someone else was dragging in version.lib before just hiding the bug and not anymore. Another example that doesn't name sdl2:

wxbase33ud.lib(dlmsw.cpp.obj) : error LNK2019: unresolved external symbol GetFileVersionInfoSizeW referenced in function "class wxString __cdecl GetFileVersion(class wxString const &)" (?GetFileVersion@@YA?AVwxString@@AEBV1@@Z)
wxbase33ud.lib(dlmsw.cpp.obj) : error LNK2019: unresolved external symbol GetFileVersionInfoW referenced in function "class wxString __cdecl GetFileVersion(class wxString const &)" (?GetFileVersion@@YA?AVwxString@@AEBV1@@Z)
wxbase33ud.lib(dlmsw.cpp.obj) : error LNK2019: unresolved external symbol VerQueryValueW referenced in function "class wxString __cdecl GetFileVersion(class wxString const &)" (?GetFileVersion@@YA?AVwxString@@AEBV1@@Z)
main-pkconfig.exe : fatal error LNK1120: 3 unresolved externals

@dg0yt
Copy link
Contributor

dg0yt commented Nov 6, 2025

I guess the problem is

libversion:arm64-windows-static-md:/debug/lib/version.lib
libversion:arm64-windows-static-md:/lib/version.lib

from #48066 hiding version.lib from Windows.

@BillyONeal
Copy link
Member

Ah, yes, that'd do it. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants