-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[libcamera] Add libcamera port #45018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your PR. Please adjust the line indentation in file |
- LD_PRELOAD='@LIBCAMERA_V4L2_SO@' | ||
+ if [ $debug = 0 ] ; then | ||
+ LD_PRELOAD="$SCRIPTPATH/../v412-compat.so" | ||
+ else | ||
+ LD_PRELOAD="$SCRIPTPATH/../../v412-compat.so" | ||
+ fi | ||
else | ||
- LD_PRELOAD="$LD_PRELOAD "'@LIBCAMERA_V4L2_SO@' | ||
+ if [ $debug = 0 ] ; then | ||
+ LD_PRELOAD="$LD_PRELOAD " "$SCRIPTPATH/../v412-compat.so" | ||
+ else | ||
+ LD_PRELOAD="$LD_PRELOAD " "$SCRIPTPATH/../../v412-compat.so" | ||
+ fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The else
part lacks indent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? I don't see it, if you're talking about l32 it should be indented like that because its the else corresponding to the first if statement on l25
"libgnutls", | ||
"libunwind", | ||
"libyaml", | ||
"libyuv", | ||
"openssl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it needs both libgnutls and openssl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested, it won't build without both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In src/libcamera/meson.build, openssl libcrypto is an alternative to libgnutls. More uses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libcrypto isn't in vcpkg I believe, so that isn't an option at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libssl and libcrypto are binaries from openssl. So the picture confirms my guess: libgnutls or openssl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libssl and libcrypto are binaries from openssl. So the picture confirms my guess: libgnutls or openssl.
yes, but in practice it doesn't work, tried on my vm and it refused to build without both present. Don't know why
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
… add-libcamera
ports/libcamera/portfile.cmake
Outdated
vcpkg_configure_meson( | ||
SOURCE_PATH "${SOURCE_PATH}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several "auto" options. They may need explicit control to avoid installation order issues with binary artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the only auto options I'll leave is for the pipelines(since it just builds everything that's compatible with the target), and the android platform as generic
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
… add-libcamera
CI fail seems to be some sort of upstream server crash, is there a way to restart the pipeline on my end?
|
Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all(no optional deps)find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.