Skip to content

[yasm] Fix the build error #44977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[yasm] Fix the build error #44977

wants to merge 2 commits into from
+65 −61

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented Apr 11, 2025 •
edited
Loading

Fixes #44941, the upstream fix PR: yasm/yasm#286.
Fix the following errors:

CMake Error at cmake/modules/YasmMacros.cmake:74 (get_target_property):
  The LOCATION property may not be read from target "re2c".  Use the target
  name directly with add_custom_command, or use the generator expression
  $<TARGET_FILE>, as appropriate.
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 11, 2025
@ajtribick
Copy link
Contributor

Just to clarify here: I did not author the upstream pull request, I merely came across it when checking for whether there was any work done in the upstream repo to support CMake 4.0.

dg0yt
dg0yt reviewed Apr 12, 2025
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cross builds, we need to point CMake to the host executables of these internal tools. Before this PR, this was done with cache variables, passed in with OPTIONS.

ports/yasm/portfile.cmake
Comment on lines -22 to -30
set(HOST_TOOLS_OPTIONS "")
if (VCPKG_CROSSCOMPILING)
list(APPEND HOST_TOOLS_OPTIONS
"-D_tmp_RE2C_EXE=${CURRENT_HOST_INSTALLED_DIR}/tools/${PORT}/re2c${VCPKG_HOST_EXECUTABLE_SUFFIX}"
"-D_tmp_GENPERF_EXE=${CURRENT_HOST_INSTALLED_DIR}/tools/${PORT}/genperf${VCPKG_HOST_EXECUTABLE_SUFFIX}"
"-D_tmp_GENMACRO_EXE=${CURRENT_HOST_INSTALLED_DIR}/tools/${PORT}/genmacro${VCPKG_HOST_EXECUTABLE_SUFFIX}"
"-D_tmp_GENVERSION_EXE=${CURRENT_HOST_INSTALLED_DIR}/tools/${PORT}/genversion${VCPKG_HOST_EXECUTABLE_SUFFIX}"
)
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Mengna-Li Mengna-Li

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[yasm] Build error on x64-windows with CMake 4.0
4 participants
@LilyWangLL @ajtribick @dg0yt @Mengna-Li