Skip to content

[slamd] Add new port #44962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

Robertleoj
Copy link

@Robertleoj Robertleoj commented Apr 10, 2025

If this PR adds a new port, please uncomment and fill out this checklist:

  • [ x] Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • [x ] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • [ x] The versioning scheme in vcpkg.json matches what upstream says.
  • [ ]x The license declaration in vcpkg.json matches what upstream says.
  • [ ]x The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • [ x] The generated "usage text" is accurate. See adding-usage for context.
  • [ x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • [ ]x Only one version is in the new port's versions file.
  • [ x] Only one version is added to each modified port's versions file.

@Robertleoj
Copy link
Author

@microsoft-github-policy-service agree

@Robertleoj
Copy link
Author

The build is failing for exactly the triplet that I am using (x64_linux), but it builds fine for me. I can't seem to access the build log - what could be going wrong here?

@LilyWangLL LilyWangLL changed the title Robertleoj/slamd [slamd] Add new port Apr 11, 2025
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 11, 2025
@LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL marked this pull request as draft April 11, 2025 06:14
@Robertleoj
Copy link
Author

@LilyWangLL the build fails on

#include <format>

which is a c++20 feature - do you not support it? I specify that the project follows c++23 standard with

set(CMAKE_CXX_STANDARD 23)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

Any reason that this doesn't work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants