Skip to content

Updated linux bash completion #44961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

karnigen
Copy link

It appears that the current vcpkg Bash autocompletion is quite outdated and doesn't function correctly. I'm submitting this pull request with improvements for Linux. I'm not certain if other operating systems need similar modifications.

@Mengna-Li Mengna-Li self-assigned this Apr 11, 2025
@Mengna-Li Mengna-Li added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Apr 11, 2025
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed in https://github.com/microsoft/vcpkg/blob/master/scripts/vcpkg_completion.bash rather than added as a new file.

@karnigen
Copy link
Author

I'm using bash-completion version 2.11 (2020), and the current version is 2.16 (2024). Older versions of bash-completion might work with the original vcpkg_completion.bash file, so I've created a new one. I don't have the ability to verify different versions of bash-completion.

@karnigen
Copy link
Author

@microsoft-github-policy-service agree

@karnigen
Copy link
Author

In last commit:

  • Refined bash completion with improved flag completion;
  • Reverted to the original filename scripts/vcpkg_completion.bash.
  • Does not require the presence of external bash-completion routines to function.
  • Tested on Bash 5.1..

@karnigen karnigen requested a review from BillyONeal April 13, 2025 20:47
@Mengna-Li Mengna-Li added the info:reviewed Pull Request changes follow basic guidelines label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants