Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SomeMerges About Build OpenSceneGraph With -j1, etc #41127

Closed
wants to merge 0 commits into from

Conversation

12225n
Copy link

@12225n 12225n commented Sep 23, 2024

No description provided.

@12225n
Copy link
Author

12225n commented Sep 23, 2024

While Build OpenSceneGraph, The Cmd Print That The Memory Is Not Enough, And I Change The .cmake To Build The OpenSceneGraph With -j1, And Could Build It,

@12225n 12225n marked this pull request as draft September 23, 2024 04:44
@12225n 12225n marked this pull request as ready for review September 23, 2024 04:45
@12225n
Copy link
Author

12225n commented Sep 23, 2024

This Is Really Useful For The Developors All over the World, which can Build OpenSceneGraph Without Errors, You Know?

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Is Really Useful For The Developors All over the World, which can Build OpenSceneGraph Without Errors, You Know?

This is not useful and not acceptable. It pessimizes the build for all users.

Users that have a machine with insufficient RAM/cores ratio must adjust VCPKG_MAX_CONCURRENCY.
#41088 (comment)

@dg0yt
Copy link
Contributor

dg0yt commented Sep 23, 2024

CI build time effect:

  • before: osg:x64-windows: SUCCEEDED: 8 min
  • after: osg:x64-windows: SUCCEEDED: 1.8 h

@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 23, 2024
@12225n 12225n marked this pull request as draft September 23, 2024 08:16
@12225n 12225n closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants