[ffmpeg] Add vulkan decoding as feature #40711
Conversation
|
@microsoft-github-policy-service agree |
JellyO1
force-pushed
the
b39042
branch
4 times, most recently
from
28ce3b5
to
9664b83
Compare
LilyWangLL
added
the
category:port-feature
ports/ffmpeg/vcpkg.json
Outdated
| @@ -655,6 +655,13 @@ | |||
| "libvpx" | |||
| ] | |||
| }, | |||
| "vulkan": { | |||
| "description": "H.264, HEVC and AV1 decoding via Vulkan", | |||
| "supports": "!osx & !arm", | |||
There was a problem hiding this comment.
I'm not sure if these are the proper flags, according to HWAccelIntro it only supports Linux and Windows but I'm not sure which architecture, (linux | windows) & !arm might be a better fit.
There was a problem hiding this comment.
I think (linux | windows) & !arm is better.
There was a problem hiding this comment.
@LilyWangLL Do you know that android, bsd and mingw is unsupported?
There was a problem hiding this comment.
Sorry, I didn't take other contexts into account; I only focused on what the author said only supports Linux and Windows.
There was a problem hiding this comment.
@dg0yt Android as far as I know is not supported, bsd and mingw I'm unsure.
| @@ -520,6 +520,14 @@ else() | |||
| set(WITH_VPX OFF) | |||
| endif() | |||
|
|
|||
| if ("vulkan" IN_LIST FEATURES) | |||
| set(OPTIONS "${OPTIONS} --enable-vulkan") | |||
| set(WITH_VULKAN ON) | |||
There was a problem hiding this comment.
This variable is a hint:
The new feature probably needs dependencies, changes to the wrapper, and maybe CI coverage via vcpkg-ci-ffmpeg.
There was a problem hiding this comment.
It seems that ffmpeg expects vulkan to be on the system according to the ffmpeg configure:
if enabled vulkan; then
check_pkg_config_header_only vulkan "vulkan >= 1.3.277" "vulkan/vulkan.h" "defined VK_VERSION_1_3" ||
check_cpp_condition vulkan "vulkan/vulkan.h" "defined(VK_VERSION_1_4) || (defined(VK_VERSION_1_3) && VK_HEADER_VERSION >= 277)"
fi
Would adding the vulkan port as a dependency be the right path?
This fixes #39042.
If this PR updates an existing port, please uncomment and fill out this checklist:
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.