-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg-tool-gn] Build gn from source on 16 KiB page arm64-Linux #39474
Draft
ADKaster
wants to merge
1
commit into
microsoft:master
Choose a base branch
from
ADKaster:vcpkg-tool-gn-build-from-source
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161
−19
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| include_guard(GLOBAL) | ||
| function(z_vcpkg_get_host_page_size) | ||
| if(NOT TARGET_TRIPLET STREQUAL _HOST_TRIPLET) | ||
| message(FATAL_ERROR "z_vcpkg_get_host_page_size() must only be called from a host port build") | ||
| endif() | ||
|
|
||
| set(BUILD_DIR "${CURRENT_BUILDTREES_DIR}/host_page_size") | ||
| set(SRC "${BUILD_DIR}/get_host_page_size.c") | ||
|
|
||
| file(WRITE "${SRC}" " | ||
| #include <stdlib.h> | ||
| #ifdef _WIN32 | ||
| #include <windows.h> | ||
| #else | ||
| #include <unistd.h> | ||
|
|
||
| #if defined __APPLE__ | ||
| #include <sys/sysctl.h> | ||
| #elif defined __linux__ | ||
| #include <stdio.h> | ||
| #elif (defined(__FreeBSD__) || defined(__NetBSD__)) | ||
| #include <sys/param.h> | ||
| #else | ||
| #error unrecognized platform | ||
| #endif | ||
| #endif | ||
|
|
||
| #include <stdio.h> | ||
| int main() { | ||
| long result = 0; | ||
| size_t cache_line_size = 0; | ||
| #ifdef _WIN32 | ||
| SYSTEM_INFO si; | ||
| DWORD bufferSize = 0; | ||
| DWORD i = 0; | ||
| SYSTEM_LOGICAL_PROCESSOR_INFORMATION *buffer = 0; | ||
|
|
||
| GetSystemInfo(&si); | ||
| result = si.dwSizes; | ||
| #else | ||
| result = sysconf(_SC_PAGESIZE); | ||
| #endif | ||
| printf(\"%ld\", result); | ||
|
|
||
| return 0; | ||
| } | ||
| ") | ||
|
|
||
| # FIXME: Is there a vcpkg approved :tm: try_run replacement? | ||
| vcpkg_find_acquire_program(CLANG) | ||
| vcpkg_execute_required_process( | ||
| COMMAND "${CLANG}" -o "${BUILD_DIR}/get_host_page_size" "${SRC}" | ||
| WORKING_DIRECTORY "${BUILD_DIR}" | ||
| LOGNAME "get_host_page_size-compile" | ||
| ) | ||
|
|
||
| execute_process( | ||
| COMMAND "${BUILD_DIR}/get_host_page_size" | ||
| OUTPUT_VARIABLE RUN_OUTPUT | ||
| OUTPUT_STRIP_TRAILING_WHITESPACE | ||
| ERROR_VARIABLE RUN_ERROR | ||
| ) | ||
|
|
||
| if (NOT RUN_ERROR STREQUAL "") | ||
| message(FATAL_ERROR "Error running get_host_page_size: ${RUN_ERROR}") | ||
| endif() | ||
|
|
||
| message(STATUS "Host page size: ${RUN_OUTPUT}") | ||
| set(Z_VCPKG_HOST_PAGE_SIZE "${RUN_OUTPUT}" PARENT_SCOPE) | ||
| endfunction() | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need it.
projectsubdir with regularCMakeLists.txt.vcpkg_cmake_configure(SOURCE_PATH "${CURRENT_PORT_DIR}/project" ...)- it will pass the actual toolchain settings.Make the configuration always succeed, and make it write a result file (aligned via
OPTIONS "-DRESULT_FILE=${CURRENT_BUILDTREES_DIR}/result-${TARGET_TRIPLET}.cmake") with the desired information.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @ADKaster for response. Can you address the review suggestions? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LilyWangLL , sorry for the late reply. I don't think I'll have the capacity to address the comments on this issue.