[llvm-openmp,openmp] add a meta-package for OpenMP #39389
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| # Uses llvm-openmp from Vcpkg for Clang and AppleClang and the native OpenMP implementation for all other compilers. | ||
|
|
||
| set(_CMAKE_MODULE_PATH "${CMAKE_MODULE_PATH}") | ||
| if(CMAKE_CXX_COMPILER_ID MATCHES "^(Clang|AppleClang)$") | ||
|
There was a problem hiding this comment. so how to use it also with MSVC, if I would like to? There was a problem hiding this comment. Realistically, you should probably simply use the LLVM OpenMP implementation included with MSVC, available by setting |
||
| list(PREPEND CMAKE_MODULE_PATH "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/share/llvm-openmp") | ||
| endif() | ||
| _find_package(${ARGS}) | ||
| set(CMAKE_MODULE_PATH "${_CMAKE_MODULE_PATH}") | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New ports are not allowed to add wrapper files anymore, and as additional information, compiler condition is not allowed in portfile.cmake, it could be determined in the CMakeLists.txt of project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you be more specific?
FindOpenMP.cmakeis an official CMake Find module. That's the case where wrappers might be appropriate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure how to modify it.
@data-queue Could you help to take a look? Thanks.