Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffmpeg] Enable D3D12VA on Windows #39322

Closed

Conversation

julianxhokaxhiu
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

FFMpeg seems to support it just fine for a while, but was never enabled for this port.
See https://www.gyan.dev/ffmpeg/builds/#about-these-builds

FFMpeg seems to support it just fine for a while, but was never enabled for this port.
See https://www.gyan.dev/ffmpeg/builds/#about-these-builds
@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 17, 2024
@MonicaLiu0311
Copy link
Contributor

Please get failure logs here:

BUILD_ARCH=x86_64
OPTION_VARIABLE=OPTIONS_x86_64
=== CONFIGURING ===
Unknown option "--enable-d3d12va".
See /d/b/ffmpeg/src/n6.1.1-92c5eda8dc.clean/configure --help for available options.

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft June 17, 2024 03:01
@kadirlua
Copy link
Contributor

Please get failure logs here:

BUILD_ARCH=x86_64
OPTION_VARIABLE=OPTIONS_x86_64
=== CONFIGURING ===
Unknown option "--enable-d3d12va".
See /d/b/ffmpeg/src/n6.1.1-92c5eda8dc.clean/configure --help for available options.

As I know, this config option has been added in ffmpeg 7.0.

@julianxhokaxhiu
Copy link
Contributor Author

As I know, this config option has been added in ffmpeg 7.0.

You're right, sorry not sure how I missed that. I'll add a comment on #38011 to ask if possible to be added there. Closing this PR as it will never work on 6.1.1. Sorry and thanks again

@kadirlua
Copy link
Contributor

As I know, this config option has been added in ffmpeg 7.0.

You're right, sorry not sure how I missed that. I'll add a comment on #38011 to ask if possible to be added there. Closing this PR as it will never work on 6.1.1. Sorry and thanks again

No problem, after #38011 completed you can create new one or open this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants