[sentry-native] update to 0.7.6 #39255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
suggested changes
Jun 12, 2024
There was a problem hiding this comment.
find_dependency needs CMakeFindDependencyMacro, and it must be used before including the exported targets. Can you please check these prerequisites?
(We might just leave the original find_package(foo REQUIRED) to reduce patching - if a dependency isn't found, the port is broken.)
|
@dg0yt, I can make an additional patch to change lines like |
AenBleidd
force-pushed
the
vko_update_sentry-native_to_076
branch
from
dabad9f
to
98cad7c
Compare
|
Commenting in getsentry/sentry-native#1007 (comment) reminded me that it also breaks any optional |
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
AenBleidd
force-pushed
the
vko_update_sentry-native_to_076
branch
from
98cad7c
to
ee78cb0
Compare
|
Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.