Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kerbal] Add new port #35600

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[kerbal] Add new port #35600

merged 1 commit into from
Dec 14, 2023

Conversation

WentsingNee
Copy link
Contributor

@WentsingNee WentsingNee commented Dec 11, 2023

If this PR adds a new port, please uncomment and fill out this checklist:

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@WentsingNee
Copy link
Contributor Author

@microsoft-github-policy-service agree

@WentsingNee
Copy link
Contributor Author

@microsoft-github-policy-service agree

@MonicaLiu0311 MonicaLiu0311 changed the title [kerbal] Add port files for new library Kerbal [kerbal] Add new port Dec 12, 2023
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 12, 2023
Co-authored-by: MonicaLiu <110024546+MonicaLiu0311@users.noreply.github.com>
@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows (header files found):

kerbal provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(Kerbal CONFIG REQUIRED)
  target_link_libraries(main PRIVATE Kerbal::kerbal)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Dec 13, 2023
@vicroms vicroms merged commit 85ade25 into microsoft:master Dec 14, 2023
15 checks passed
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
Co-authored-by: MonicaLiu <110024546+MonicaLiu0311@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants