Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libxslt] do not require default features of libxml2 #35565

Merged

Conversation

vthib
Copy link
Contributor

@vthib vthib commented Dec 8, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Mark the libxml2 dependency as not requiring default features. This allows the user to reduce the feature set of the libxml2 transitive dependency.

Before:

$ .\vcpkg install libxslt[core] libxml2[core] --dry-run
Computing installation plan...
The following packages will be built and installed:
  * libiconv:x64-windows -> 1.17#1
  * liblzma:x64-windows -> 5.4.4
    libxml2[core,iconv,lzma,zlib]:x64-windows -> 2.11.6#1
    libxslt:x64-windows -> 1.1.37#2
  * vcpkg-cmake:x64-windows -> 2023-05-04
  * vcpkg-cmake-config:x64-windows -> 2022-02-06#1
  * zlib:x64-windows -> 1.3
Additional packages (*) will be modified to complete this operation.

After:

$ .\vcpkg install libxslt[core] libxml2[core] --dry-run
Computing installation plan...
The following packages will be built and installed:
    libxml2:x64-windows -> 2.11.6#1
    libxslt:x64-windows -> 1.1.37#3
  * vcpkg-cmake:x64-windows -> 2023-05-04
  * vcpkg-cmake-config:x64-windows -> 2022-02-06#1
Additional packages (*) will be modified to complete this operation.

@Adela0814 Adela0814 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines labels Dec 11, 2023
@vicroms vicroms merged commit 8308c14 into microsoft:master Dec 12, 2023
15 checks passed
autoantwort pushed a commit to autoantwort/vcpkg that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants