Skip to content

Fix PCL compile tools - #3301

Merged
Robert Schumacher (ras0219-msft) merged 1 commit into
microsoft:masterfrom
claudiofantacci:fix/pcluuid
Apr 24, 2018
Merged

Fix PCL compile tools#3301
Robert Schumacher (ras0219-msft) merged 1 commit into
microsoft:masterfrom
claudiofantacci:fix/pcluuid

Conversation

@claudiofantacci

@claudiofantacci Claudio Fantacci (claudiofantacci) commented Apr 24, 2018

Copy link
Copy Markdown
Contributor

Add missing boost-related definition
add_definitions(-DBOOST_UUID_RANDOM_GENERATOR_COMPAT)
using a patch at configuration time.

Fixes #3289

Add missing boost definition using a patch.

Better compile from HEAD.
@ras0219-msft
Robert Schumacher (ras0219-msft) merged commit f0767d3 into microsoft:master Apr 24, 2018
@ras0219-msft

Copy link
Copy Markdown
Contributor

Thanks for the PR!

@taketwo

Copy link
Copy Markdown

A fix for this issue was merged into PCL master, so the patch should be no longer needed.

@claudiofantacci

Claudio Fantacci (claudiofantacci) commented Jun 11, 2018

Copy link
Copy Markdown
Contributor Author

A fix for this issue was merged into PCL master, so the patch should be no longer needed.

Great and thanks for reporting! 👍

The patch is still needed because is applied to PCL release 1.8.1. You may no longer need it if you install the port using --HEAD. In this case, however, the other patches need also to be checked as they may not be applicable anymore on the new version of their corresponding file on master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants